dts: msm8226: msm8226-samsung: millet3g: new device #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NekoCWD
force-pushed
the
main
branch
2 times, most recently
from
651b2f6 to
ff0d0e1
Compare
TravMurav
reviewed
Dec 8, 2024
| compatible = "samsung,millet3g", "samsung,millet"; | ||
| lk2nd,match-bootloader = "T331*"; | ||
|
|
||
| lk2nd,dtb-files = "msm8226-samsung-millet3g"; |
There was a problem hiding this comment.
Suggested change
| lk2nd,dtb-files = "msm8226-samsung-millet3g"; | |
| lk2nd,dtb-files = "msm8226-samsung-millet3g", | |
| "msm8226-samsung-milletwifi"; |
perhaps this assuming the original dtb for milletwifi is compatible with this?
Or just
Suggested change
| lk2nd,dtb-files = "msm8226-samsung-millet3g"; | |
| lk2nd,dtb-files = "msm8226-samsung-milletwifi"; |
even for now, assuming you don't need to change anything at all for them both to work on the same dtb
There was a problem hiding this comment.
I want to separate dtbs. millet-common dtsi, milletwifi and millet3g dtbs.
Need i do this changes?
Co-authored-by: Nikita Travkin <nikitos.tr@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 3g variant of samsung-millet.
It based on msm8226 instead of apq8026 which used in milletwifi (SM-T330)
Pictures
Tablet running lk2nd photo