Feature: menu: add continue option

[NekoCWD]

shakaled.mp4

[wonderfulShrineMaidenOfParadise]

What's the difference when you can press reboot and boot by partition boot or extlinux?

[NekoCWD]

What's the difference when you can press reboot and boot by partition boot or extlinux?

You can continue boot from fastboot. Useful if you built lk2nd with force fastboot option

[wonderfulShrineMaidenOfParadise]

You can continue boot from fastboot.

Can I just fastboot reboot?

[NekoCWD]

You can continue boot from fastboot.

Can I just fastboot reboot?

Yes, you can. But only if lk2nd built without LK2ND_FORCE_FASTBOOT=1

[NekoCWD]

Change to draft. I need to modify fastboot continue cmd

[wonderfulShrineMaidenOfParadise]

only if lk2nd built without LK2ND_FORCE_FASTBOOT=1

Fair enough. So we need this option only when LK2ND_FORCE_FASTBOOT=1 and it's not useful when LK2ND_FORCE_FASTBOOT=0.

[TravMurav]

FTR: I'd generally prefer as few changes to the original CAF code as possible. In this case I too wonder why just using fastboot continue doesn't work?

[NekoCWD]

FTR: I'd generally prefer as few changes to the original CAF code as possible. In this case I too wonder why just using fastboot continue doesn't work?

It won't use lk2nd boot(from extlinux conf)

[TravMurav]

FTR: I'd generally prefer as few changes to the original CAF code as possible. In this case I too wonder why just using fastboot continue doesn't work?

It won't use lk2nd boot(from extlinux conf)

well, it's supposed to... https://github.com/msm8916-mainline/lk2nd/blob/main/app/aboot/aboot.c#L4676

[NekoCWD]

FTR: I'd generally prefer as few changes to the original CAF code as possible. In this case I too wonder why just using fastboot continue doesn't work?

It won't use lk2nd boot(from extlinux conf)

well, it's supposed to... main/app/aboot/aboot.c#L4676

Oh, my bad. Sorry.

I think the GUI menu can be used in different scenarios. For example, you can continue booting without a PC.

I understand your point. But I think it is rational to reuse the code

[TravMurav]

I don't mind adding a menu item for "continue" as long as it ends up just calling the same cmd_continue in aboot, and works the same way. I think in this case the change should be fairly trivial

[NekoCWD]

I don't mind adding a menu item for "continue" as long as it ends up just calling the same cmd_continue in aboot, and works the same way. I think in this case the change should be fairly trivial

Thanks. I will edit my changes

[NekoCWD]

Do i need to add LK2ND_FORCE_FASTBOOT=1 check?

[TravMurav]

Thanks!

Also just in case would like to clarify that this "extern" pattern as was suggested is generally bad but we make an exception here since we want to avoid touching code outside of /lk2nd dir as much as possible :)