Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dts: msm8952: Add Motorola Moto E5 Plus (MSM8917) #486

Merged
merged 1 commit into from
Feb 9, 2025
Merged

dts: msm8952: Add Motorola Moto E5 Plus (MSM8917) #486

merged 1 commit into from
Feb 9, 2025

Conversation

Operachi061
Copy link
Contributor

@Operachi061 Operachi061 commented Jan 27, 2025 •
edited
Loading

Add Motorola Moto E5 Plus (hannah) (MSM8917) Variant.

@Operachi061 Operachi061 changed the title Motorola Moto E5 Plus Fix dts: Motorola Moto E5 Plus Fix Jan 27, 2025
@Operachi061 Operachi061 changed the title dts: Motorola Moto E5 Plus Fix dts: msm8917: Motorola Moto E5 Plus Fix Jan 27, 2025
barni2000
barni2000 suggested changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@barni2000 barni2000 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove MSM8937 variant.

There are 3 hannah variant. 8917 8937 and 8940

@Operachi061
Copy link
Contributor Author

Fact, there are rhannah for MSM8917, ahannah for MSM8937 and hannah for MSM8940.

I will try to fix it

@barni2000
Copy link
Contributor

barni2000 commented Jan 27, 2025 •
edited
Loading

Fact, there are rhannah for MSM8917, ahannah for MSM8937 and hannah for MSM8940.

I will try to fix it

Yes but all have androidboot.device=hannah.

Btw my MSM8937 variant says this

(bootloader) version-bootloader: moto-msm8937-BF.15
(bootloader) product: hannah
(bootloader) board: hannah

further more 8940 and 8917 variants have different display panels. (maybe 8917 is same)

@Operachi061
Copy link
Contributor Author

Operachi061 commented Jan 27, 2025 •
edited
Loading

So I only changed the name of the model in .dts and in devices.md. That's all (I think)

@barni2000
Copy link
Contributor

barni2000 commented Jan 27, 2025 •
edited
Loading

So I only changed the name of the model in .dts and in devices.md. That's all (I think)

I would left 8937 as it is (hannah) (MSM8937) and 8917 variant can be (hannah)(MSM8917)

barni2000
barni2000 suggested changes Jan 27, 2025
View reviewed changes
lk2nd/device/dts/msm8952/msm8917-mtp.dts Outdated
@@ -11,6 +11,30 @@
};

&lk2nd {
motorola-hannah {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the indentation

lk2nd/device/dts/msm8952/msm8937-mtp.dts Outdated
hannah {
model = "Motorola Moto E5 Plus (hannah) (MSM8937)";

motorola-hannah {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

lk2nd/device/dts/msm8952/msm8937-mtp.dts Outdated
@@ -41,7 +41,7 @@
};
};

l38011 {
l38011 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@Operachi061
Copy link
Contributor Author

Wait, I fix something

@Operachi061
Copy link
Contributor Author

I discovered, that neovim I think he showed me wrong, so I had to change it via other editor

barni2000
barni2000 suggested changes Jan 27, 2025
View reviewed changes
Documentation/devices.md Outdated
@@ -81,7 +81,8 @@
- Leeco s2
- Lenovo K5 Play (l38011)
- Motorola Moto E5 (nora)
- Motorola Moto E5 Plus (hannah) (MSM8937)
- Motorola Moto E5 Plus (hannah) (msm8917)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Motorola Moto E5 Plus (hannah) (msm8917)
- Motorola Moto E5 Plus (hannah) (MSM8917)

Documentation/devices.md Outdated
@@ -81,7 +81,8 @@
- Leeco s2
- Lenovo K5 Play (l38011)
- Motorola Moto E5 (nora)
- Motorola Moto E5 Plus (hannah) (MSM8937)
- Motorola Moto E5 Plus (hannah) (msm8917)
- Motorola Moto E5 Plus (hannah) (msm8937)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Motorola Moto E5 Plus (hannah) (msm8937)
- Motorola Moto E5 Plus (hannah) (MSM8937)

@barni2000
Copy link
Contributor

barni2000 commented Jan 27, 2025 •
edited
Loading

Please squash your commits and use dts: msm8952: prefix in your commit message title

A good commit message title could be dts: msm8952: Add Motorola Moto E5 Plus (MSM8917)

@Operachi061 Operachi061 changed the title dts: msm8917: Motorola Moto E5 Plus Fix dts: msm8952: Add Motorola Moto E5 Plus (MSM8917) Jan 27, 2025
@Operachi061
Copy link
Contributor Author

Done

@Operachi061
Copy link
Contributor Author

And thanks for help.

@Operachi061 Operachi061 force-pushed the main branch 4 times, most recently from 0088fa8 to 45905f2 Compare January 27, 2025 21:44
@Operachi061
Copy link
Contributor Author

yep

@Operachi061
Copy link
Contributor Author

Operachi061 commented Jan 27, 2025 •
edited
Loading

I don't know why I was struggling with it half hour, but it's very strange (or I am idk)

@barni2000
Copy link
Contributor

I don't know why I was struggling with it half hour, but it's very strange (or I am idk)

you still miss the prefixes from the commit message, otherwise it looks good now.

@Operachi061
Copy link
Contributor Author

which prefixes ?

@barni2000
Copy link
Contributor

which prefixes ?

dts: msm8952:

@Operachi061
Copy link
Contributor Author

Done

@barni2000
Copy link
Contributor

I this really needs these workaround? https://wiki.postmarketos.org/wiki/Motorola_Moto_E5_Plus_(motorola-hannah)#LK2nd_Building

@Operachi061
Copy link
Contributor Author

Operachi061 commented Jan 28, 2025 •
edited
Loading

It can be normally installed but this is guide if you want build Lk2nd for the Motorola hannah. It has 'LK2ND_QCDTBS` option, because firmware of motorola hannah supports only images with QCDT format 👍️

@barni2000
Copy link
Contributor

barni2000 commented Jan 28, 2025 •
edited
Loading

It can be normally installed but this is guide if you want build Lk2nd for the Motorola hannah. It has 'LK2ND_QCDTBS` option, because firmware of motorola hannah supports only images with QCDT format.

MSM9837 variant works with ADTB, you should set QCDTBS in rules.mk and document if still some workaround is needed.

@Operachi061
Copy link
Contributor Author

Operachi061 commented Jan 28, 2025 •
edited
Loading

well, I guess it's just MSM8917 then, with the QCDT support. I installed Lk2nd via pmbootstrap without problems so idk how it works.

@Operachi061
Copy link
Contributor Author

Btw we can edit the wiki, which can support MSM8937 and MSM8917.

@Operachi061
Copy link
Contributor Author

Operachi061 commented Jan 28, 2025 •
edited
Loading

and we can btw if you want text about kernel or the other things related to MSM8x7 on the matrix, cuz I am on the msm8937-mainline group, then you can ping me via "@\operachi" (ignore this slash)

barni2000
barni2000 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@barni2000 barni2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No workarounds are need @TravMurav you can merge it if it seems fine to you.

@TravMurav TravMurav merged commit 2785816 into msm8916-mainline:main Feb 9, 2025
42 checks passed
@TravMurav
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barni2000 barni2000 barni2000 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Operachi061 @barni2000 @TravMurav