Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: msm8909-1gb-qrd-skuc: add Haier G151 #488

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

cozychizu
Copy link
Contributor

lk1st for Haier G151 (MSM8909) alongside with the panel drivers, tested working like how the stock bootloader would.

Comment on lines 107 to 109
lk2nd,dtb-files = "msm8909-haier-g151";
panel {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lk2nd,dtb-files = "msm8909-haier-g151";
panel {
lk2nd,dtb-files = "msm8909-haier-g151";
panel {

compatible = "haier,g151-panel";

qcom,mdss_dsi_ili9806e_fwvga_video {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Comment on lines 8 to 10
#include "lk_panel_ili9806e_fwvga_hsd_hlt_video.h"
#include "lk_panel_ili9806e_fwvga_hsd_huashi_video.h"
#include "lk_panel_ili9806e_fwvga_video.h"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#include "lk_panel_ili9806e_fwvga_hsd_hlt_video.h"
#include "lk_panel_ili9806e_fwvga_hsd_huashi_video.h"
#include "lk_panel_ili9806e_fwvga_video.h"
#include "lk_panel_ili9806e_fwvga_hsd_hlt_video.h"
#include "lk_panel_ili9806e_fwvga_hsd_huashi_video.h"
#include "lk_panel_ili9806e_fwvga_video.h"

You don't really have 3 panels on 1 phone at the same time. Remove the other 2 panels you don't have.

@cozychizu cozychizu force-pushed the main branch 2 times, most recently from 8589c27 to a3e549c Compare January 29, 2025 14:17
Comment on lines 114 to 116
};
qcom,mdss_dsi_ili9806e_fwvga_hsd_huashi_video {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
qcom,mdss_dsi_ili9806e_fwvga_hsd_huashi_video {
};
qcom,mdss_dsi_ili9806e_fwvga_hsd_huashi_video {

@@ -64,6 +64,7 @@
- Acer Liquid Z330 (T01)
- CAT B35
- FarEasTone Smart 506 (quirky - see comment in `lk2nd/device/dts/msm8909/msm8909-1gb-qrd-skuc.dts`)
- Haier G151 / Andromax A (quirky - see comment in `lk2nd/device/dts/msm8909/msm8909-1gb-qrd-skuc.dts`)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where can we learn more about Andromax A?

Copy link
Contributor Author

@cozychizu cozychizu Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a pretty obscure device, to be honest theres not much information about it online. Andromax A is known internally as Haier G151, possibly a rebrand of an unreleased device, however there's a working downstream kernel based on CAF where I get all the information of the hardware

@cozychizu cozychizu force-pushed the main branch 2 times, most recently from f408e89 to 759ee35 Compare January 29, 2025 22:07
@@ -88,4 +88,38 @@
};
};
};

haier-g151 {
model = "Haier G151";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Andromax A also included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the codename of the device is the same as haier g151, so it covers those two devices. shall i also include Andromax A as the model name?

* plus panel drivers for the device
@TravMurav TravMurav merged commit 487fb49 into msm8916-mainline:main Feb 9, 2025
42 checks passed
@TravMurav
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants