dts: apq8909-1gb-qrd-skue: add leoven yoga tablet 10 WIFI #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
missclick i will test it later |
TravMurav
reviewed
Feb 9, 2025
TravMurav
reviewed
Feb 9, 2025
| @@ -4,7 +4,12 @@ | |||
| #include <lk2nd.dtsi> | |||
|
|
|||
| / { | |||
| qcom,msm-id = <QCOM_ID_MSM8909 0>; | |||
| //some variant of lxf_p5100 bootloder is quirky and they only select | |||
| //<QCOM_ID_MSM8909 0x00 0x102 0x00 0x109 0x00 0x113 0x00> | |||
There was a problem hiding this comment.
As already suggested, please decode those constants to appropriate QCOM_ID and split to two-cell values. Don't think you need to repeat the array twice. I'd also actually appreciate if you can isolate your device to one specific msm-id, not add all of them (i.e. to know if it matches 3g-only 8209 or wifi only 8009)
There was a problem hiding this comment.
hell yeah the 8 in one has the same issue
There was a problem hiding this comment.
i am thinking about making a dedicated dts for them
exkc
changed the title
exkc
changed the title
exkc
changed the title
exkc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.