Update Priority Queue Cloud Pattern #122
Open
+486
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to .NET 8.0 Updated README
skabou
force-pushed
the
priority-queue-update
branch
from
c57c76c to
617a48f
Compare
ckittel
requested changes
Mar 14, 2024
Member
ckittel
left a comment
ckittel
left a comment
There was a problem hiding this comment.
Summary:
- Use Entra ID
- Use new Azure SDK dependency injection model
- How do we get this to not just be a pub-sub example?
- Use bicep for the azure resource deployments
That third item is worrying me a bit, not sure how best to proceed. Would be glad to talk it over w/ ya!
Comment on lines
7
to
24
| .ConfigureFunctionsWorkerDefaults() | ||
| .ConfigureAppConfiguration((hostingContext, config) => | ||
| { | ||
| config.AddJsonFile("local.settings.json", optional: true, reloadOnChange: true); | ||
| }) | ||
| .ConfigureServices(services => | ||
| { | ||
| var configuration = services.BuildServiceProvider().GetRequiredService<IConfiguration>(); | ||
|
|
||
| services.AddSingleton(configuration); | ||
|
|
||
| services.AddSingleton<ServiceBusClient>(sp => | ||
| { | ||
| var connectionString = configuration.GetValue<string>("ServiceBusConnectionString"); | ||
| return new ServiceBusClient(connectionString); | ||
| }); | ||
| }) | ||
| .Build(); |
Member
There was a problem hiding this comment.
Can this get converted to:
services.AddAzureClients(cb => {
cb.AddServiceBusClient(...)
});https://learn.microsoft.com/azure/azure-functions/dotnet-isolated-process-guide?tabs=linux#register-azure-clients -- The PG is trying to get folks to use this model for Azure SDK clients intead of the custom approach like you have here.
priority-queue/PriorityQueueConsumerHigh/PriorityQueueConsumerHighFn.cs
Outdated
Show resolved
Hide resolved
priority-queue/PriorityQueueConsumerHigh/PriorityQueueConsumerHigh.csproj
Outdated
Show resolved
Hide resolved
priority-queue/PriorityQueueConsumerLow/PriorityQueueConsumerLow.csproj
Outdated
Show resolved
Hide resolved
priority-queue/PriorityQueueConsumerLow/PriorityQueueConsumerLowFn.cs
Outdated
Show resolved
Hide resolved
* Improvements. Bicep file. Settings. Moved to managed identity. Run func start * Removing VS requirement * deleting any --------- Co-authored-by: Federico Arambarri <v-fearam>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to .NET 8.0
Updated README