Skip to content

Commit

Permalink
ci: git-validation can go suck an egg
Browse files Browse the repository at this point in the history
Signed-off-by: Miquel Sabaté Solà <mikisabate@gmail.com>
  • Loading branch information
mssola committed May 10, 2024
1 parent a1fcf17 commit 65286e6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 33 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,7 @@ jobs:
with:
version: ${{ matrix.emacs_version }}

- uses: actions/setup-go@v5

- uses: actions/checkout@v4

- name: Install git-validation
run: go install github.com/vbatts/git-validation@latest

- name: make ci
run: make ci
19 changes: 0 additions & 19 deletions CONTRIBUTING.org
Original file line number Diff line number Diff line change
Expand Up @@ -31,25 +31,6 @@ style. You can run these checkers by performing:
$ make lint
#+END_SRC

*** Git validation

In order to ensure that the git log is as maintainable as possible, the
[[https://github.com/vbatts/git-validation][git-validation]] tool is used. You can install this tool by running:

#+BEGIN_SRC bash
$ go get -u github.com/vbatts/git-validation
#+END_SRC

If you already have this tool installed, then simply perform:

#+BEGIN_SRC bash
$ make git-validation
#+END_SRC

Note that if you don't have this tool installed the task will do nothing (it
will just print a help message). This is done so when running the default make
task this doesn't interrupt it.

*** Load test

In order to test that this theme can be actually loaded, run:
Expand Down
10 changes: 1 addition & 9 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ $(OBJECTS): %.elc: %.el
ci: version all

.PHONY: test
test: lint git-validation checkdoc load-test
test: lint checkdoc load-test

# Maybe it would've been nicer to use Cask or something like that, but it
# doesn't have too many dependencies so it should be fine for now.
Expand Down Expand Up @@ -70,14 +70,6 @@ fix-stdlib-changes:
lint: vendor fix-stdlib-changes
@$(BATCH) -l elisp-lint.el -f elisp-lint-files-batch $(ELS)

.PHONY: git-validation
git-validation:
ifeq (, $(shell which git-validation 2> /dev/null))
@echo "You don't have 'git-validation' installed, consider installing it (see the CONTRIBUTING.org file)."
else
@git-validation -q -range 7d38ca68163c..HEAD -travis-pr-only=false
endif

.PHONY: load-test
load-test:
@$(BATCH) -nw --load soria-theme.el \
Expand Down

0 comments on commit 65286e6

Please sign in to comment.