feat: add --share flag to upload profiles to profiler.firefox.com#745
Open
shekhirin wants to merge 1 commit intomstange:mainfrom
Open
feat: add --share flag to upload profiles to profiler.firefox.com#745shekhirin wants to merge 1 commit intomstange:mainfrom
--share flag to upload profiles to profiler.firefox.com#745shekhirin wants to merge 1 commit intomstange:mainfrom
Conversation
Upload gzipped profile to Firefox Profiler API and return shareable URL. Opens browser automatically unless --no-open is passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upload gzipped profile to Firefox Profiler API and return shareable URL. Opens browser automatically unless
--no-openis passed.Note that only runs with
--presymbolicatewill include symbols in the uploaded profile. @mstange I wonder if we should only allow to run with--sharewhen--presymbolicateis provided, or just log a warning when it's not?Instructions for uploading profiles: https://github.com/firefox-devtools/profiler/blob/main/docs-developer/loading-in-profiles.md
Example
Profile from the screenshot: https://share.firefox.dev/4aaiOFM