Display branch symbols in the asm/v1 endpoint#747
Open
canova wants to merge 3 commits intomstange:mainfrom
Open
Display branch symbols in the asm/v1 endpoint#747canova wants to merge 3 commits intomstange:mainfrom
canova wants to merge 3 commits intomstange:mainfrom
Conversation
This will allow us to see the changes in the following commit.
Both of them had some quirks that we had to overcome differently. On ARM64, some opcodes can take multiple operands, and the pc offset operand could be in different positions. On ARM32, branch offsets are shifted by either 1 or 2. But the immediate value that is stored inside the yaxpeax_arm Operand enum is a non-shifted value. So we have to shift them ourselves.
This commit adds branch symbols to the asm/v1 API inside samply-api. It achieves this by loading the symbol map right before we decode, and pass it as an argument so we can append the branch symbol besides the instruction. Currently we only do this in x86_64, ARM64 and ARM32, and not x86.
canova
force-pushed
the
asm-branch-symbols
branch
from
42a44a2 to
900c812
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the asm/v1 endpoint to display branch symbols besides the branch instruction immediate operands. This will help us understand which functions we are branching off to.
This PR depends on #746 the first two commits also belong to it, only 3rd commit belongs to this PR.