fix(linux): --reuse-threads thread naming and recycling#748
Open
shekhirin wants to merge 1 commit intomstange:mainfrom
Open
fix(linux): --reuse-threads thread naming and recycling#748shekhirin wants to merge 1 commit intomstange:mainfrom
--reuse-threads thread naming and recycling#748shekhirin wants to merge 1 commit intomstange:mainfrom
Conversation
Two issues were causing incorrect behavior with --reuse-threads on Linux: 1. In handle_fork, passing the parent thread's name caused all threads to attempt recycling with the same name at creation time, before they got their actual names via COMM events. Now we pass None - threads get their names and recycle properly when the COMM event arrives. 2. In rename_non_main_thread, when recycling was enabled but no recycled thread with the target name existed, the rename was silently skipped. Added else branch to fall back to rename_without_recycling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two issues were causing incorrect behavior with
--reuse-threadson Linux:In
handle_fork, passing the parent thread's name caused all threads to attempt recycling with the same name at creation time, before they got their actual names via COMM events. Now we pass None - threads get their names and recycle properly when the COMM event arrives.In
rename_non_main_thread, when recycling was enabled but no recycled thread with the target name existed, the rename was silently skipped. Added else branch to fall back torename_without_recycling.