transaction: Expose PAM error types and test them all #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
improved-errors
branch
4 times, most recently
from
550b3ec to
5a2b9d1
Compare
And use them instead of C ones. Given that we have strings for them we can easily implement the error interface for it too.
3v1n0
force-pushed
the
improved-errors
branch
2 times, most recently
from
c4e91d9 to
c748bf4
Compare
Use pam_debug.so to generate pam configurations at test time and check if the returned values expect the ones we want.
…error If the transaction fails during start, there's no way to get the error detail in a programmatic way, so let's inherit from error to allow more per-type checks.
3v1n0
force-pushed
the
improved-errors
branch
3 times, most recently
from
4331963 to
d790098
Compare
3v1n0
force-pushed
the
improved-errors
branch
from
d790098 to
8f2d042
Compare
Transactions save the status of each operation in a status field, however such field could be written concurrently by various operations, so we need to be sure that: - We always return the status for the current operation - We store the status in a atomic way so that other actions won't create write races In general, in a multi-thread operation one should not rely on Transaction.Status() to get info about the last operation.
|
This is now part of #15 so let's close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pam_debug.so to check if expected errors are returned, and provide a new error type