Update example code to call Transaction.End #17
Conversation
example_test.go
Outdated
| switch s { | ||
| case pam.PromptEchoOff: | ||
| fmt.Print(msg) | ||
| fmt.Printf("%s", msg) |
There was a problem hiding this comment.
| fmt.Printf("%s", msg) | |
| fmt.Printf("%s: ", msg) |
There was a problem hiding this comment.
I know this looks bizarre, but on my machine (running Arch), I get the following values for the message string:
- Echo on:
login:(lowercase, colon, no trailing space) - Echo off:
Password:(uppercase, colon, traliing space)
Do you get a different result? I guess maybe I should just leave it as it was previously since this probably depends on the PAM module running on your specific system.
There was a problem hiding this comment.
Yeah, definitely... It's up to the module to define those..
It's quite weird that it does assumptions on the UI is running though, since a module could message can be print anywhere (including a non-terminal UI), so it's not supposed to send that.
There was a problem hiding this comment.
Adding the space is fine in any case though... Since in the password case we won't see anything printing anyways.
There was a problem hiding this comment.
I suspect most people ignore the message strings and print whatever they want instead. I'll revert those lines.
example_test.go
Outdated
| pw, err := term.ReadPassword(int(os.Stdin.Fd())) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
| fmt.Println() | ||
| return string(pw), nil | ||
| case pam.PromptEchoOn: | ||
| fmt.Print(msg) | ||
| fmt.Printf("%s ", msg) |
There was a problem hiding this comment.
| fmt.Printf("%s ", msg) | |
| fmt.Printf("%s: ", msg) |
msteinert
force-pushed
the
update-example
branch
from
eb52470 to
4537bb5
Compare
No description provided.