Add Docker support with workflows for building and pushing images #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosblog
suggested changes
Mar 5, 2025
| id: get_latest_release | ||
| uses: pozetroninc/github-action-get-latest-release@master | ||
| with: | ||
| owner: PixelWelt |
There was a problem hiding this comment.
Wrong owner
Suggested change
| owner: PixelWelt | |
| owner: msteudtn |
| - "80:80" | ||
| volumes: | ||
| - ./data:/var/www/html/data | ||
| - ./extras:var/www/html/extras |
There was a problem hiding this comment.
missing slash
Suggested change
| - ./extras:var/www/html/extras | |
| - ./extras:/var/www/html/extras |
| ### Installation mit Docker | ||
| #### Nutzung des fertigen Images | ||
|
|
||
| 1. installiere [docker](https://docs.docker.com/engine/install/ubuntu/) und docker-compose |
There was a problem hiding this comment.
Don't link to specific Linux Platform, use the generic site
Suggested change
| 1. installiere [docker](https://docs.docker.com/engine/install/ubuntu/) und docker-compose | |
| 1. installiere [docker](https://docs.docker.com/engine/install/) und docker-compose |
|
|
||
| #### Baue das image selber | ||
|
|
||
| 1. installiere [docker](https://docs.docker.com/engine/install/ubuntu/) und docker-compose |
There was a problem hiding this comment.
Don't link to specific Linux Platform, use the generic site
Suggested change
| 1. installiere [docker](https://docs.docker.com/engine/install/ubuntu/) und docker-compose | |
| 1. installiere [docker](https://docs.docker.com/engine/install/) und docker-compose |
| uses: pozetroninc/github-action-get-latest-release@master | ||
| with: | ||
| owner: PixelWelt | ||
| repo: ThalamOS |
There was a problem hiding this comment.
Wrong repo
Suggested change
| repo: ThalamOS | |
| repo: mat-o-wahl |
| ports: | ||
| - "80:80" | ||
| volumes: | ||
| - ./data:/var/www/html/data |
There was a problem hiding this comment.
Directory extras is missing, to stay consistent with docker-compose.yml
There was a problem hiding this comment.
English part of the added documentation is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feel free to contact me if you have any questions