Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makes moretrees game agnostic #37

Merged
merged 8 commits into from
May 26, 2024
Merged

makes moretrees game agnostic #37

merged 8 commits into from
May 26, 2024

Conversation

wsor4035
Copy link
Contributor

@wsor4035 wsor4035 commented Mar 23, 2024 •
edited
Loading

makes moretrees game agnostic

requires:

steps:

  • boot minetest without crashing
  • handle biomes/nodes spawning on
  • balancing or anything else? (might not be needed)

occurrences of default:* not cared about

  • everything in screenshot.lua
  • default specific overrides in general, gated these to default in this pr
  • everything not already handled in node_defs.lua
  • surfaces in tree defs, as long as they have other nodes to be placed on
  • some tools that have other counterparts that are comparable
  • some surfaces, since they have some game compatible nodes in them

@wsor4035
Copy link
Contributor Author

will require adding some more materials to xcompat

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Mar 27, 2024
@wsor4035
Copy link
Contributor Author

nodes are all handled

@wsor4035
Copy link
Contributor Author

discovered while two legacy spawn defs has biomes, we dont honor that in the translate function, so thats not a concern at this time

@wsor4035 wsor4035 marked this pull request as ready for review May 24, 2024 03:09
@wsor4035 wsor4035 mentioned this pull request May 25, 2024
Closed
Niklp09
Niklp09 reviewed May 26, 2024
View reviewed changes
init.lua Outdated Show resolved Hide resolved
@wsor4035 wsor4035 requested a review from Niklp09 May 26, 2024 13:16
@wsor4035 wsor4035 merged commit f49b1c4 into master May 26, 2024
2 checks passed
@wsor4035 wsor4035 deleted the game_agnostic_with_xcompat branch May 26, 2024 15:08
@wsor4035 wsor4035 mentioned this pull request Sep 6, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BuckarooBanzay BuckarooBanzay Awaiting requested review from BuckarooBanzay

@Niklp09 Niklp09 Awaiting requested review from Niklp09

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wsor4035 @Niklp09 @BuckarooBanzay