Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tune for voxel garden #40

Merged
merged 2 commits into from
May 27, 2024
Merged

tune for voxel garden #40

merged 2 commits into from
May 27, 2024

Conversation

wsor4035
Copy link
Contributor

alternative to #38

@j-r thoughts?

@wsor4035 wsor4035 requested a review from Niklp09 May 26, 2024 15:35
@wsor4035 wsor4035 added the enhancement New feature or request label May 26, 2024
@j-r
Copy link

j-r commented May 26, 2024

Thanks for working on this. Looks good to me, will take it for a test drive (but I don't expect problems).

My unqualified (not having your experience in this domain) personal opinion is that in the long run it probably would be better to base the decision on some kind of feature API instead of game id, but at this point it probably isn't possible to come up with an adequate list of features.

Anyway, I'd like to suggest to add the (internal) settings entry after all and have the gameid check only there in one place with a suitable comment, better documenting why that particular feature is disabled (since probably not everybody knows all VG gameplay feature details).

@wsor4035
Copy link
Contributor Author

thoughts on the latest commit?

@j-r
Copy link

j-r commented May 27, 2024

thoughts on the latest commit?

Makes me happy:-)

EDIT: and is working, too! (note that leaf decay doesn't work quite right yet, but that is a separate issue)

@wsor4035 wsor4035 merged commit 1b6914b into master May 27, 2024
2 checks passed
@wsor4035 wsor4035 deleted the voxelgardentuning branch May 27, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants