Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no squash] Disable jungletree generation when default isn't available #43

Merged
merged 2 commits into from
May 30, 2024

Conversation

Niklp09
Copy link
Member

@Niklp09 Niklp09 commented May 30, 2024

Resolves #42 and maybe #12.

  • Remove unused params from biome_defs (I kept biomes due to
    --biomes eventually?
    )
  • Disable jungletree generation when default isn't available

Might make sense to generate jungletrees when the game provides somethink like xcompat.materials.jungletree (not implemented in xcompat yet). Then we could nuke the copied node completely and alias it when default is loaded.

@Niklp09 Niklp09 added the enhancement New feature or request label May 30, 2024
@Niklp09 Niklp09 requested a review from wsor4035 May 30, 2024 14:41
Copy link
Contributor

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good solution for now

@wsor4035 wsor4035 merged commit 517c9dc into master May 30, 2024
2 checks passed
@wsor4035 wsor4035 deleted the jungletree_fun branch May 30, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moretrees:jungletree_trunk registration for non mtg games
2 participants