Skip to content

Commit

Permalink
Changed variable name per reviewer suggestion.
Browse files Browse the repository at this point in the history
Variable changed from use_default_digilines_rules to enable_vertical_digilines_connectivity.
  • Loading branch information
Deathwing777 authored Nov 2, 2024
1 parent 31b9dc2 commit 0e37040
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions common.lua
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ pipeworks.rules_all = {{x=0, y=0, z=1},{x=0, y=0, z=-1},{x=1, y=0, z=0},{x=-1, y
pipeworks.mesecons_rules={{x=0,y=0,z=1},{x=0,y=0,z=-1},{x=1,y=0,z=0},{x=-1,y=0,z=0},{x=0,y=1,z=0},{x=0,y=-1,z=0}}

local digilines_enabled = minetest.get_modpath("digilines") ~= nil
if digilines_enabled and pipeworks.use_default_digilines_rules then
if digilines_enabled and pipeworks.enable_vertical_digilines_connectivity then

This comment has been minimized.

Copy link
@eshattow

eshattow Nov 3, 2024

minor nit, this is fine but could be better said as pipeworks.enable_digiline_connection_vertical to fit the existing pipeworks configuration variable style

pipeworks.digilines_rules=digiline.rules.default
else
-- When using these rules, digiline signals are NOT conducted vertically, despite any rotation to the node. This
-- breaks expected behavior with digiline conducting tubes. Some servers however, may have builds that relied on
-- the lack of vertical conduction and may wish to revert to this behavior.
-- These rules break vertical connectivity to deployers, node breakers, dispensers, and digiline filter injectors

This comment has been minimized.

Copy link
@eshattow

eshattow Nov 3, 2024

Keep, this is all we need to know, not the editorial/opinion following.

-- via digiline conducting tubes. Changing them may break some builds on some servers, so the setting was added

This comment has been minimized.

Copy link
@eshattow

eshattow Nov 3, 2024

Delete editorial/opinion. The information on line 23 is all that is needed here.

-- for server admins to be able to revert to the old "broken" behavior as some builds may use it as a "feature".

This comment has been minimized.

Copy link
@eshattow

eshattow Nov 3, 2024

Delete editorial/opinion. The information on line 23 is all that is needed here.

-- See https://github.com/mt-mods/pipeworks/issues/64
pipeworks.digilines_rules={{x=0,y=0,z=1},{x=0,y=0,z=-1},{x=1,y=0,z=0},{x=-1,y=0,z=0},{x=0,y=1,z=0},{x=0,y=-1,z=0}}
end
Expand Down
2 changes: 1 addition & 1 deletion default_settings.lua
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ local settings = {
delete_item_on_clearobject = true,
use_real_entities = true,
entity_update_interval = 0,
use_default_digilines_rules = true,
enable_vertical_digilines_connectivity = true,

This comment has been minimized.

Copy link
@eshattow

eshattow Nov 3, 2024

minor nit, this is fine but could be better said as pipeworks.enable_digiline_connection_vertical to fit the existing pipeworks configuration variable style

}

pipeworks.toggles = {}
Expand Down
2 changes: 1 addition & 1 deletion settingtypes.txt
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ pipeworks_entity_update_interval (Entity Update Interval) float 0 0 0.8
# or bottom faces, regardless of the node rotation. This breaks expected behavior with digiline
# conducting tubes, so it is recommended to enable this option unless you have specific builds
# that make use of the lack of vertical digiline connectivity and those are more important to you.
pipeworks_use_default_digilines_rules (Use the default rules from the digilines mod) bool true
enable_vertical_digilines_connectivity (Use the default rules from the digilines mod) bool true

This comment has been minimized.

Copy link
@eshattow

eshattow Nov 3, 2024

minor nit, this is fine but could be better said as pipeworks.enable_digiline_connection_vertical to fit the existing pipeworks configuration variable style


# if set to true, items passing through teleport tubes will log log where they came from and where they went.
pipeworks_log_teleport_tubes (Log Teleport Tubes) bool false
Expand Down

0 comments on commit 0e37040

Please sign in to comment.