-
Notifications
You must be signed in to change notification settings - Fork 157
Add timeout support for get_n_chars/4 #3136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jjtolton
wants to merge
11
commits into
mthom:master
Choose a base branch
from
jjtolton:discussion-3035
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4e80ed4
Add timeout support for get_n_chars/4
jjtolton d2d513c
WIP: Implement timeout=0 as no timeout and add tests
jjtolton 2c014fc
Refactor tests to follow testing guide structure
jjtolton 971a715
Fix incomplete UTF-8 handling after get_n_chars/4 timeout
jjtolton 5168293
Use structural equality (==) in incomplete UTF-8 tests
jjtolton c80f6cf
Use double-quote notation for character lists in tests
jjtolton 0385469
Apply setup_call_cleanup pattern to test cases
jjtolton b6b44a1
Add module qualification to test predicates
jjtolton ce0c1e6
Add nonblock tests for get_n_chars/4
jjtolton b57b8ef
Register get_n_chars and incomplete_utf8 tests
jjtolton 9b28c5c
Flatten nested setup_call_cleanup calls in tests
jjtolton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Partial data" in the sense that it may be less than
Nchars?