Fix parser to reject incomplete reductions like ([, ({, (( #3139
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you give an example where |
|
... and where is a problem with the comma? |
UWN
reviewed
Oct 26, 2025
src/tests/syntax_errors.pl
Outdated
| % Test that (( produces syntax error | ||
| test("(( should produce syntax_error", ( | ||
| catch( | ||
| (read_from_chars("((}.", _), false), |
There was a problem hiding this comment.
This example is not very convincing, since it always produced a syntax error (for whatever reason). So what is its point?
There was a problem hiding this comment.
(... divergent branches, git status says I should do git pull)
Author
There was a problem hiding this comment.
perhaps looking at the combined testing branch would be better:
https://github.com/jjtolton/scryer-prolog/tree/combined-testing
That has digits, this, and double bars
There was a problem hiding this comment.
(... divergent branches,
git statussays I should dogit pull)
Forget it, your combined branch is it!
UWN
reviewed
Oct 26, 2025
src/tests/syntax_errors.pl
Outdated
| % Test that {( produces syntax error (already tested in ISO conformity) | ||
| test("{( should produce syntax_error", ( | ||
| catch( | ||
| (read_from_chars("{(}.", _), false), |
Fixes mthom#3138 The parser was incorrectly accepting expressions like ([ and ({ as valid syntax, parsing them as atoms instead of rejecting them as incomplete reductions. This fix adds checks in reduce_brackets() to reject when an opening parenthesis is followed by: - Opening bracket [ - Opening curly brace { Note: (, and (( were already correctly rejected by existing checks. This brings the behavior in line with how curly braces work, where {[ and {( correctly produce syntax errors. Added tests in src/tests/syntax_errors.pl to verify the fix and prevent regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3138