Skip to content

Commit

Permalink
Upgrade to Node v20 (#1419)
Browse files Browse the repository at this point in the history
* Use node v20

* Bump astro now that we use node v20

* Revert "Bump astro now that we use node v20"

This reverts commit 206ee3e.

* Bump astro to newest v1.x
  • Loading branch information
gjsjohnmurray authored Jan 13, 2025
1 parent fa0680b commit a8aec9b
Show file tree
Hide file tree
Showing 16 changed files with 1,414 additions and 862 deletions.
4 changes: 2 additions & 2 deletions .devcontainer/postCreateCommand.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ sleep 5
# Suppress warnings triggered by engine value package.json of a VS Code extension
yarn config set ignore-engines true -g

# Build with Node.js version 16
# Build with Node.js version 20
. $NVM_DIR/nvm.sh
nvm install 16
nvm install 20

# Appending this to .bashrc means shells opened within the project tree will use the Node.js version specified in .nvmrc in the project root,
# provided no overriding .nvmrc is found between the shell's cwd and that root folder.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

strategy:
matrix:
node-version: [16.x]
node-version: [20.x]

steps:
- uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-formatter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

strategy:
matrix:
node-version: [16.x]
node-version: [20.x]

steps:
- uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20
6 changes: 3 additions & 3 deletions build-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@
"babel-loader": "^8.0.5",
"copy-webpack-plugin": "^5.0.0",
"cross-env": "^5.2.0",
"css-loader": "^4.2.1",
"css-loader": "^6.11.0",
"dotenv": "^8.2.0",
"file-loader": "^4.2.0",
"mini-css-extract-plugin": "^0.8.0",
"mini-css-extract-plugin": "^2.9.2",
"no-emit-webpack-plugin": "^2.0.1",
"node-sass": "^7.0.1",
"node-sass": "^9.0.0",
"optimize-css-assets-webpack-plugin": "^5.0.3",
"raw-loader": "^4.0.1",
"resolve-url-loader": "^3.1.1",
Expand Down
1 change: 0 additions & 1 deletion build-tools/webpack/webview.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,5 @@ module.exports = exports = function getWebviewConfig({ entries, packagePath }) {
const minCssExtract = {
loader: MiniCssExtractPlugin.loader,
options: {
hmr: false,
},
};
Loading

0 comments on commit a8aec9b

Please sign in to comment.