//(Floor Division) on CockroachDB query formatting fixed
#1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Badstübner <jonas.badstuebner@hetzner-cloud.de>
gjsjohnmurray
approved these changes
Nov 2, 2023
|
We just published 0.28.1 with this change included. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The floor division opeator
//is special to CockroachDB I think. I found it in other DBMS' Documentation but only for comments (and none of them are officiall supported bysqltools), so keeping these two slashes without whitespace inbetween no matter what should always at least be "more valid" than splitting them apart.Therefore I do not expect unwanted side effects because of this change.
fixes #1234
Thank you for your contribution!
Before submitting this PR, please make sure:
There are warnings, but not because of my change