Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mssql QoL changes and a major bug fix #1399

Merged
merged 3 commits into from
Nov 28, 2024
Merged

mssql QoL changes and a major bug fix #1399

merged 3 commits into from
Nov 28, 2024

Conversation

fzhem
Copy link
Contributor

@fzhem fzhem commented Nov 15, 2024

Describe here what is this PR about and what we are achieving merging this.

  • Database is optional now in connection UI
  • Use database specific information_schema in queries, fixing empty schemas, tables/views when clicking on a database that is not "master"
  • Return empty list when schema is inaccessible, fixing "sqltools.getChildrenForTreeItem" when clicking on inaccessible schema in sidebar

Thank you for your contribution!
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You have made the needed changes to the docs
  • You have written a description of what is the purpose of this pull request above

This fixes an issue with sidebar where users can't see database tables/views
This resolves 'sqltools.getChildrenForTreeItem' failed error when clicking on an inaccessible schema.
Copy link
Collaborator

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this.

@gjsjohnmurray gjsjohnmurray merged commit 0b58466 into mtxr:dev Nov 28, 2024
2 checks passed
@DamianGlowala
Copy link

@gjsjohnmurray when can we expect a new release containing this change?

@gjsjohnmurray
Copy link
Collaborator

@DamianGlowala I hope to have time to do a release in January.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants