[charts-pro] Improve vertical zoom slider thumb on mobile #20439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardobelchior
added
type: bug
|
Deploy preview: https://deploy-preview-20439--material-ui-x.netlify.app/ Bundle size report
|
| } | ||
|
|
||
| // Prevent scrolling on touch devices when dragging the thumb | ||
| thumb.addEventListener('touchmove', preventDefault, { passive: false }); |
Member
Author
There was a problem hiding this comment.
This is the actual fix
Comment on lines
+89
to
+90
| thumb.addEventListener('pointercancel', onPointerEnd); | ||
| thumb.addEventListener('pointerup', onPointerEnd); |
Member
Author
There was a problem hiding this comment.
This is just handling the pointercancel event
bernardobelchior
requested review from
JCQuintas and
alexfauquette
as code owners
CodSpeed Performance ReportMerging #20439 will not alter performanceComparing Summary
Footnotes |
alexfauquette
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve vertical zoom slider thumb on mobile.
Before:
Screen.Recording.2025-11-24.at.16.05.43.mov
Applying
touch-action: none(initial approach):Screen.Recording.2025-11-24.at.16.06.08.mov
Using
preventDefaultintouchmove:Screen.Recording.2025-11-25.at.09.20.47.mov
Chrome on Android also seems to work:
Screen.Recording.2025-11-25.at.09.30.28.mov