Skip to content

[scheduler] Replace copied Base UI internals with @base-ui/react/internals imports#21972

Draft
flaviendelangle wants to merge 12 commits intomui:masterfrom
flaviendelangle:scheduler/replace-base-ui-copies-with-internals
Draft

[scheduler] Replace copied Base UI internals with @base-ui/react/internals imports#21972
flaviendelangle wants to merge 12 commits intomui:masterfrom
flaviendelangle:scheduler/replace-base-ui-copies-with-internals

Conversation

@flaviendelangle
Copy link
Copy Markdown
Member

@flaviendelangle flaviendelangle commented Apr 3, 2026

DO NOT MERGE BEFORE @base-ui/react is released

Applies mui/base-ui#4505

…rnals imports

Update @base-ui/react to a build from PR mui/base-ui#4505
which exposes internal utilities under @base-ui/react/internals/*.

Replace ~46 files' imports from base-ui-copy/ with proper imports:
- useRenderElement → @base-ui/react/internals/useRenderElement
- BaseUIComponentProps, NonNativeButtonProps → @base-ui/react/internals/types
- useButton → @base-ui/react/internals/use-button
- createChangeEventDetails → @base-ui/react/internals/createBaseUIEventDetails
- TemporalAdapter, TemporalSupportedObject, TemporalTimezone → @base-ui/react/internals/temporal

Delete 11 now-redundant copy files (utils/ and types/ directories).

Remaining in base-ui-copy/ (not yet available in internals):
- composite/ (CompositeList, CompositeRootContext, useCompositeListItem)
- temporal-adapter-date-fns/ (UnstableTemporalAdapterDateFns)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@flaviendelangle flaviendelangle self-assigned this Apr 3, 2026
@flaviendelangle flaviendelangle added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: scheduler Changes related to the scheduler. labels Apr 3, 2026
@mui-bot
Copy link
Copy Markdown

mui-bot commented Apr 3, 2026

Deploy preview: https://deploy-preview-21972--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 41048b7

flaviendelangle and others added 9 commits April 3, 2026 08:06
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update @base-ui/react to 4e7402b build which exposes CompositeList
and useCompositeListItem via @base-ui/react/internals/composite.

Delete the 4 remaining composite copy files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…i/react

Update @base-ui/react to 0882bfb build which exposes TemporalAdapterDateFns
via @base-ui/react/internals/temporal-adapter-date-fns.

- Replace UnstableTemporalAdapterDateFns with TemporalAdapterDateFns
- Delete the entire base-ui-copy/ directory
- Remove ./base-ui-copy export from package.json
- Add @base-ui/react as a dev dependency of the test package

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Member

@rita-codes rita-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 7, 2026
@flaviendelangle flaviendelangle force-pushed the scheduler/replace-base-ui-copies-with-internals branch from 6258e3d to 41048b7 Compare April 7, 2026 10:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: out-of-date The pull request has merge conflicts and can't be merged. scope: scheduler Changes related to the scheduler. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants