[charts] Make line series type support radial and cartesian#22050
Open
alexfauquette wants to merge 6 commits intomui:masterfrom
Open
[charts] Make line series type support radial and cartesian#22050alexfauquette wants to merge 6 commits intomui:masterfrom
alexfauquette wants to merge 6 commits intomui:masterfrom
Conversation
|
Deploy preview: https://deploy-preview-22050--material-ui-x.netlify.app/ Bundle size report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #21968
In this PR the series config can now be
axisType: 'cartesian' | 'polar';to indicate the series support bothHaving different series type for cartesian and polar series makes it tricky because they have the same seriesType (
'line') but one has some xAxis, whereas the other has a rotationAxis.In this PR I propose to add an extra
AxisTypegeneric argument to distinguish when necessary the cartesian / radialOther options
Add a
coordinateSystem?: 'cartesian' | 'radial'to the series type with the default set to cartesian.coordinateSystem === 'radial'and then get the correct type.Keep only one series type. For the axes id, we could use
xAxisId,yAxisIdfor the rotation/radius axes. Or assume radial lines have only one axis, so radial plot just ignore those.Introduce a new series type
radialLinethat copies most of the line series.