Skip to content

Add counter and 'all' switch to DNS content blockers #5223

Add counter and 'all' switch to DNS content blockers

Add counter and 'all' switch to DNS content blockers #5223

Triggered via pull request September 17, 2024 09:28
Status Success
Total duration 8m 30s
Billable time 9m
Artifacts

ios.yml

on: pull_request
Check formatting
43s
Check formatting
Run swiftlint
25s
Run swiftlint
Unit tests
8m 21s
Unit tests
Fit to window
Zoom out
Zoom in

Annotations

21 warnings
Run swiftlint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run swiftlint
swiftlint 0.57.0 is already installed and up-to-date. To reinstall 0.57.0, run: brew reinstall swiftlint
Run swiftlint: MullvadSettings/SettingsManager.swift#L50
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
Run swiftlint: Shared/LaunchArguments.swift#L49
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
Run swiftlint: PacketTunnelCore/Actor/PacketTunnelActor.swift#L283
Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines (function_body_length)
Run swiftlint: MullvadVPN/Classes/ConsolidatedApplicationLog.swift#L131
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
Check formatting
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Check formatting
swiftformat 0.54.5 already installed
Unit tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit tests: --- xcodebuild#L1
Using the first of multiple matching destinations:
Unit tests
xcbeautify 2.11.0 is already installed and up-to-date. To reinstall 2.11.0, run: brew reinstall xcbeautify
Unit tests
Failed to restore: Cache service responded with 429