Skip to content

Add counter and 'all' switch to DNS content blockers #5225

Add counter and 'all' switch to DNS content blockers

Add counter and 'all' switch to DNS content blockers #5225

Triggered via pull request September 17, 2024 09:57
Status Success
Total duration 5m 42s
Billable time 6m
Artifacts

ios.yml

on: pull_request
Check formatting
38s
Check formatting
Run swiftlint
21s
Run swiftlint
Unit tests
5m 32s
Unit tests
Fit to window
Zoom out
Zoom in

Annotations

19 warnings
Run swiftlint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run swiftlint
swiftlint 0.57.0 is already installed and up-to-date. To reinstall 0.57.0, run: brew reinstall swiftlint
Run swiftlint: MullvadSettings/SettingsManager.swift#L50
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
Run swiftlint: Shared/LaunchArguments.swift#L49
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
Run swiftlint: PacketTunnelCore/Actor/PacketTunnelActor.swift#L283
Function body should span 50 lines or less excluding comments and whitespace: currently spans 53 lines (function_body_length)
Run swiftlint: MullvadVPN/Classes/ConsolidatedApplicationLog.swift#L131
Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)
Check formatting
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit tests: --- xcodebuild#L1
Using the first of multiple matching destinations:
Unit tests: ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKitGo/wireguard.h#L26
umbrella header for module 'WireGuardKitGo' does not include header '/wireguard-go/maybenot/crates/maybenot-ffi/maybenot.h'
Unit tests: ios/MullvadREST/Transport/Shadowsocks/ShadowsocksRelaySelector.swift#L46
no calls to throwing functions occur within 'try' expression
Unit tests
xcbeautify 2.11.0 is already installed and up-to-date. To reinstall 2.11.0, run: brew reinstall xcbeautify