iOS app

Do not enter blocked state if device check has network errors #5261

Triggered via pull request September 24, 2024 11:48

buggmagnet

synchronize #6856

device-check-network-error

Status Success

Total duration 6m 33s

Billable time 7m

Artifacts –

ios.yml

on: pull_request

Annotations

20 warnings

Run swiftlint

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Run swiftlint

swiftlint 0.57.0 is already installed and up-to-date. To reinstall 0.57.0, run: brew reinstall swiftlint

Run swiftlint: MullvadSettings/SettingsManager.swift#L50

Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)

Run swiftlint: Shared/LaunchArguments.swift#L49

Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)

Run swiftlint: MullvadVPN/Classes/ConsolidatedApplicationLog.swift#L131

Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)

Run swiftlint: MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift#L132

SwiftLint rule 'function_body_length' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)

Check formatting

swiftformat 0.54.5 already installed

Unit tests

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Unit tests: --- xcodebuild#L1

Using the first of multiple matching destinations:

Unit tests: ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKitGo/wireguard.h#L29

umbrella header for module 'WireGuardKitGo' does not include header '/wireguard-go/maybenot/crates/maybenot-ffi/maybenot.h'

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1

expected canonical name for private module 'MullvadRustRuntimeProxy'

expected canonical name for private module 'MullvadRustRuntimeProxy' [-Wprivate-module]

expected canonical name for private module 'MullvadRustRuntimeProxy'

Unit tests

xcbeautify 2.11.0 is already installed and up-to-date. To reinstall 2.11.0, run: brew reinstall xcbeautify

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not enter blocked state if device check has network errors #5261

Summary