Update cell layout and behavior for obfuscation methods · mullvad/mullvadvpn-app@c00c25c

Triggered via pull request October 29, 2024 08:59

rablador

synchronize #7020

Status Success

Total duration 8m 51s

Billable time 9m

Artifacts 1

ios.yml

on: pull_request

20 warnings

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

swiftlint 0.57.0 is already installed and up-to-date. To reinstall 0.57.0, run: brew reinstall swiftlint

Run swiftlint: MullvadSettings/SettingsManager.swift#L50

Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)

Run swiftlint: Shared/LaunchArguments.swift#L49

Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)

Run swiftlint: MullvadVPN/Classes/ConsolidatedApplicationLog.swift#L131

Prefer failable `String(data:encoding:)` initializer when converting `Data` to `String` (optional_data_string_conversion)

Run swiftlint: MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift#L115

TODOs should be resolved (When ready, add navigation to ...) (todo)

Run swiftlint: MullvadVPN/View controllers/VPNSettings/VPNSettingsDataSource.swift#L313

TODOs should be resolved (When ready, add implementation...) (todo)

Run swiftlint: MullvadVPN/View controllers/VPNSettings/VPNSettingsDataSource.swift#L317

TODOs should be resolved (When ready, add implementation...) (todo)

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/setup-go@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Unit tests: --- xcodebuild#L1

Using the first of multiple matching destinations:

Unit tests: ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKit/WireGuardAdapter.swift#L606

@discardableResult declared on a function returning Void is unnecessary

Unit tests: ios/.spm/checkouts/wireguard-apple/Sources/WireGuardKit/WireGuardAdapter.swift#L606

@discardableResult declared on a function returning Void is unnecessary

Unit tests: Users/runner/Library/Developer/Xcode/DerivedData/MullvadVPN-eyvrfmadodhkonbxvnjzkuyudpjl/Build/Intermediates.noindex/MullvadVPN.build/Debug-iphonesimulator/MullvadRustRuntime.build/module.private.modulemap#L1