Skip to content

Commit

Permalink
Disable testAppStillFunctioningWhenAPIDown because of ATS in iOS 18
Browse files Browse the repository at this point in the history
  • Loading branch information
buggmagnet committed Nov 15, 2024
1 parent 2fafba2 commit 58b7353
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions ios/MullvadVPNUITests/ConnectivityTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,12 @@ class ConnectivityTests: LoggedOutUITestCase {
// swiftlint:disable function_body_length
/// Test that the app is functioning when API is down. To simulate API being down we create a dummy access method
func testAppStillFunctioningWhenAPIDown() throws {
let skipReason = """
This test is currently skipped due to a bug in iOS 18 where ATS shuts down the
connection to the API in the blocked state, despite being explicitly disabled,
and after the checks in SSLPinningURLSessionDelegate return no error.
"""
try XCTSkipIf(true, skipReason)
let hasTimeAccountNumber = getAccountWithTime()

addTeardownBlock {
Expand Down
2 changes: 1 addition & 1 deletion mullvad-ios/src/encrypted_dns_proxy.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ impl EncryptedDnsProxyState {
pub unsafe extern "C" fn encrypted_dns_proxy_init(
domain_name: *const c_char,
) -> *mut EncryptedDnsProxyState {
// SAFETY: domain_name points to a valid region of memory and contains a nul terminator.
let domain = {
// SAFETY: domain_name points to a valid region of memory and contains a nul terminator.
let c_str = unsafe { CStr::from_ptr(domain_name) };
String::from_utf8_lossy(c_str.to_bytes())
};
Expand Down

0 comments on commit 58b7353

Please sign in to comment.