Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social media to content blockers #5206

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Sep 28, 2023

Implement Social Media content blocker

  • We are still missing the strings/translations.

This change is Reviewable

@Rawa Rawa added the Android Issues related to Android label Sep 28, 2023
@Rawa Rawa self-assigned this Sep 28, 2023
@linear
Copy link

linear bot commented Sep 28, 2023

DROID-336 Add toggle for social media block list

Just add another DNS content blockers entry for Social media last in the list of content blockers.

The bit to set in the DNS resolver IP is 1 << 5 (0b00100000)

https://mullvad.slack.com/archives/C33N9MLQ7/p1692782875487679

@Rawa Rawa force-pushed the add-toggle-for-social-media-block-list-droid-336 branch from 588e08c to f4a7a02 Compare October 2, 2023 06:34
@Rawa Rawa changed the title Draft: Add social media to content blockers Add social media to content blockers Oct 2, 2023
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the add-toggle-for-social-media-block-list-droid-336 branch 2 times, most recently from fbfa7cb to 0d19f8d Compare October 2, 2023 11:59
Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 3 of 5 files reviewed, all discussions resolved (waiting on @albin-mullvad and @Pururun)

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the add-toggle-for-social-media-block-list-droid-336 branch from 0d19f8d to 76caa10 Compare October 2, 2023 13:31
@Rawa Rawa force-pushed the add-toggle-for-social-media-block-list-droid-336 branch from 76caa10 to 2d60a96 Compare October 2, 2023 14:02
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the add-toggle-for-social-media-block-list-droid-336 branch from 2d60a96 to 52927cf Compare October 2, 2023 14:04
@Pururun Pururun merged commit c2183ff into main Oct 2, 2023
12 checks passed
@Pururun Pururun deleted the add-toggle-for-social-media-block-list-droid-336 branch October 2, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants