Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login uiautomator flakiness #5276

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Oct 12, 2023


This change is Reviewable

@linear
Copy link

linear bot commented Oct 12, 2023

DROID-405 Login tests fail on CI

https://github.com/mullvad/mullvadvpn-app/actions/runs/6458123698/job/17531743437?pr=5253

INSTRUMENTATION_STATUS: numtests=3
INSTRUMENTATION_STATUS: stream=
INSTRUMENTATION_STATUS: test=testLoginWithInvalidCredentials
INSTRUMENTATION_STATUS_CODE: 1
INSTRUMENTATION_STATUS: class=net.mullvad.mullvadvpn.test.mockapi.LoginMockApiTest
INSTRUMENTATION_STATUS: current=3
INSTRUMENTATION_STATUS: id=AndroidJUnitRunner
INSTRUMENTATION_STATUS: numtests=3
INSTRUMENTATION_STATUS: stack=java.lang.IllegalArgumentException: No matches for selector within timeout (60000): BySelector [TEXT='\QLogin failed\E']
	at net.mullvad.mullvadvpn.test.common.extension.UiAutomatorExtensionsKt.findObjectWithTimeout(UiAutomatorExtensions.kt:30)
	at net.mullvad.mullvadvpn.test.mockapi.LoginMockApiTest.testLoginWithInvalidCredentials(LoginMockApiTest.kt:32)

INSTRUMENTATION_STATUS: stream=
Error in testLoginWithInvalidCredentials(net.mullvad.mullvadvpn.test.mockapi.LoginMockApiTest):
java.lang.IllegalArgumentException: No matches for selector within timeout (60000): BySelector [TEXT='\QLogin failed\E']
	at net.mullvad.mullvadvpn.test.common.extension.UiAutomatorExtensionsKt.findObjectWithTimeout(UiAutomatorExtensions.kt:30)
	at net.mullvad.mullvadvpn.test.mockapi.LoginMockApiTest.testLoginWithInvalidCredentials(LoginMockApiTest.kt:32)

INSTRUMENTATION_STATUS: test=testLoginWithInvalidCredentials
INSTRUMENTATION_STATUS_CODE: -2
INSTRUMENTATION_RESULT: stream=

Time: 105.573
There was 1 failure:
1) testLoginWithInvalidCredentials(net.mullvad.mullvadvpn.test.mockapi.LoginMockApiTest)
java.lang.IllegalArgumentException: No matches for selector within timeout (60000): BySelector [TEXT='\QLogin failed\E']
	at net.mullvad.mullvadvpn.test.common.extension.UiAutomatorExtensionsKt.findObjectWithTimeout(UiAutomatorExtensions.kt:30)
	at net.mullvad.mullvadvpn.test.mockapi.LoginMockApiTest.testLoginWithInvalidCredentials(LoginMockApiTest.kt:32)

FAILURES!!!

@Rawa Rawa force-pushed the login-tests-fail-on-ci-droid-405 branch 2 times, most recently from 478aed6 to d201a98 Compare October 12, 2023 08:58
@Rawa Rawa added the Android Issues related to Android label Oct 12, 2023
@Rawa Rawa self-assigned this Oct 12, 2023
@Rawa Rawa changed the title WIP: Fix login uiautomator flakiness Fix login uiautomator flakiness Oct 12, 2023
@Rawa Rawa force-pushed the login-tests-fail-on-ci-droid-405 branch from d201a98 to a7c27d9 Compare October 12, 2023 11:00
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit 7f092c3 into main Oct 12, 2023
13 checks passed
@albin-mullvad albin-mullvad deleted the login-tests-fail-on-ci-droid-405 branch October 12, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants