Fix missing test runner binary in CI #5585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
force-pushed
the
fix/missing-test-runner-binary-in-ci
branch
from
45a9ac2
to
0018bda
Compare
|
@dlon OK'd this PR AFK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new image used for building the test framework (since #5569) overrode
CARGO_TARGET_DIR, which lead to thetest-runnerartifact being output in an unexpected target directory. This PR sets the expectedCARGO_TARGET_DIRexplicitly.This PR also drive-by fixes an issue with the macOS test-runner not being able to start the mullvad-daemon after it has been stopped by a test case, causing the test suite to halt.
This change is