Lift IS_PLAY_BUILD to DI #5598
Merged
Lift IS_PLAY_BUILD to DI #5598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rawa
requested review from
Pururun,
albin-mullvad and
sabercodic
and removed request for
Pururun
albin-mullvad
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Pururun
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
Pururun
force-pushed
the
avoid-using-is_play_build-directly-in-ui-droid-584
branch
from
b7c5aed
to
1df9f4b
Compare
Pururun
deleted the
avoid-using-is_play_build-directly-in-ui-droid-584
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use IS_PLAY_BUILD directly in ViewModel's and UI, this makes it unnecessarily hard to do testing when one is not able to set it easily. This PR lifts the property up so it is injected instead.
This change is