Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rendering bitmaps above 100MB #6071

Merged

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Apr 4, 2024

Also add a out of memory check for even larger app icons.


This change is Reviewable

Copy link

linear bot commented Apr 4, 2024

@Rawa Rawa self-assigned this Apr 4, 2024
@Rawa Rawa added the Android Issues related to Android label Apr 4, 2024
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun marked this pull request as ready for review April 4, 2024 14:55
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rawa please update the changelog as well

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ✔️

Reviewable status: 3 of 9 files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git history looks a bit strange with unrelated things 🤔 Please have a look at that

Reviewable status: 3 of 9 files reviewed, 1 unresolved discussion (waiting on @Rawa)


CHANGELOG.md line 56 at r3 (raw file):

#### Android

Skip this empty line

@Rawa Rawa force-pushed the crash-in-split-tunneling-due-to-too-large-app-icon-droid-846 branch from 9814ada to 2820351 Compare April 5, 2024 11:27
@Rawa Rawa requested a review from albin-mullvad April 5, 2024 11:28
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: 4 of 9 files reviewed, all discussions resolved

@Rawa Rawa force-pushed the crash-in-split-tunneling-due-to-too-large-app-icon-droid-846 branch from 2820351 to 380080c Compare April 5, 2024 13:18
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa merged commit e859f00 into main Apr 5, 2024
27 checks passed
@Rawa Rawa deleted the crash-in-split-tunneling-due-to-too-large-app-icon-droid-846 branch April 5, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants