Add a safe FFI wrapper in wireguard-go-rs

[hulthe]

TODO

• Resolve TODOs
• Make sure android works (again)

---

This change is 

[linear]

DES-938 Make the Rust bindings exposed by `wireguard-go-rs` safe

[MarkusPettersson98]

Reviewed 1 of 10 files at r1, 3 of 80 files at r3, 7 of 13 files at r6, 71 of 76 files at r7, 2 of 2 files at r8, 5 of 5 files at r9, 1 of 1 files at r10, all commit messages.
Reviewable status: all files reviewed, 13 unresolved discussions (waiting on @hulthe and @Serock3)

---

talpid-wireguard/src/connectivity_check.rs line 218 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

I've checked, and using blocking_lock here is fine. Tokio will panic if this method is called from a tokio runtime

Yeah, I also think it is fine. Maybe add a "Panics"-section to this function's doc comment which echos the same gotcha as blocking_lock?:)

---

wireguard-go-rs/libwg/libwg.go line 47 at r9 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

Keep or remove? Whaddya think?

Keep if we currently can't replace it with (a) more specific error(s), otherwise remove it in favor of it/those:)

---

wireguard-go-rs/src/lib.rs line 68 at r10 (raw file):

    /// for the tunnel device and logging. For targets other than android, this also takes an MTU value.
    ///
    /// The `logging_callback` let's you provide a Rust function that receivec any logging output

receives*

Code quote:

receivec

---

wireguard-go-rs/src/lib.rs line 69 at r10 (raw file):

    ///
    /// The `logging_callback` let's you provide a Rust function that receivec any logging output
    /// from wireguard-go. `logging_context` is an value that will be passed to each invocation of

a*

Code quote:

an

---

wireguard-go-rs/src/lib.rs line 109 at r10 (raw file):

    ///
    /// **NOTE:** You should take extra care to avoid copying any secrets from the config without zeroizing them afterwards.
    // NOTE: this could return a guard type with a custom Drop impl instead, but me lazy.

Would be neat ;) No need to though

Code quote:

// NOTE: this could return a guard type with a custom Drop impl instead, but me lazy.

[hulthe]

Reviewable status: 83 of 86 files reviewed, 12 unresolved discussions (waiting on @MarkusPettersson98 and @Serock3)

---

wireguard-go-rs/libwg/libwg.go line 47 at r9 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Keep if we currently can't replace it with (a) more specific error(s), otherwise remove it in favor of it/those:)

We could, but it would involve refactoring wireguard-go. I'm removing this TODO from here as I feel it's slightly out of scope of this PR

[MarkusPettersson98]

Reviewed 2 of 2 files at r11, 1 of 1 files at r12, all commit messages.
Reviewable status: all files reviewed, 12 unresolved discussions (waiting on @hulthe and @Serock3)

---

talpid-wireguard/src/wireguard_go/mod.rs line 230 at r10 (raw file):

            {
                let socket_v4 = unsafe { wgGetSocketV4(handle) };
                let socket_v6 = unsafe { wgGetSocketV6(handle) };

You did already wrap these in safe functions, right? 😊

Code quote:

                let socket_v4 = unsafe { wgGetSocketV4(handle) };
                let socket_v6 = unsafe { wgGetSocketV6(handle) };

[hulthe]

Reviewable status: 83 of 86 files reviewed, 12 unresolved discussions (waiting on @MarkusPettersson98 and @Serock3)

---

talpid-wireguard/src/connectivity_check.rs line 218 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Yeah, I also think it is fine. Maybe add a "Panics"-section to this function's doc comment which echos the same gotcha as blocking_lock?:)

Done.

---

wireguard-go-rs/src/lib.rs line 68 at r10 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

receives*

Done.

---

wireguard-go-rs/src/lib.rs line 69 at r10 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

a*

Done.

[MarkusPettersson98]

Reviewed 3 of 3 files at r13, 1 of 1 files at r14, all commit messages.
Reviewable status: all files reviewed, 9 unresolved discussions (waiting on @hulthe and @Serock3)

[MarkusPettersson98]

Reviewed 1 of 2 files at r15, 1 of 1 files at r16, all commit messages.
Reviewable status: all files reviewed, 10 unresolved discussions (waiting on @hulthe and @Serock3)