Fixes for firebase e2e still sometimes failing #6653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albin-mullvad
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
niklasberglund
force-pushed
the
fixes-for-firebase-e2e-still-sometimes-failing
branch
from
50cebba
to
e5d66dd
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
niklasberglund
force-pushed
the
fixes-for-firebase-e2e-still-sometimes-failing
branch
from
e5d66dd
to
78bef00
Compare
niklasberglund
force-pushed
the
fixes-for-firebase-e2e-still-sometimes-failing
branch
from
78bef00
to
207cc54
Compare
albin-mullvad
deleted the
fixes-for-firebase-e2e-still-sometimes-failing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e tests on Firebase are still sometimes failing due to rate limiting. This PR include some improvements related to failing tests in Firebase:
testLoginWithInvalidCredentialsbecause the requests it generates are highly rate limitedThis change is