-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeat option for e2e tests and incrementing timeout #6655
Repeat option for e2e tests and incrementing timeout #6655
Conversation
cbdfea2
to
43a8cdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)
.github/workflows/android-app.yml
line 457 at r2 (raw file):
- name: Run instrumented test script if: ${{ matrix.test-repeat != 0 }} timeout-minutes: ${{ fromJSON(steps.calculate-timeout.outputs.timeout) }}
Do we need to parse these timeouts from json?
Code quote:
fromJSON
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
.github/workflows/android-app.yml
line 457 at r2 (raw file):
It does look very odd, but fromJSON can be used to convert string to number. And the value for timeout-minutes
cannot be a numerical string.
"For numerical comparison, the
fromJSON()
function can be used to convert a string to a number"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
.github/workflows/android-app.yml
line 457 at r2 (raw file):
Previously, niklasberglund (Niklas Berglund) wrote…
It does look very odd, but fromJSON can be used to convert string to number. And the value for
timeout-minutes
cannot be a numerical string."For numerical comparison, the
fromJSON()
function can be used to convert a string to a number"
Alright, sounds good! 👍
43a8cdb
to
0b93056
Compare
This PR introduces an option for specifying how many times e2e tests should run on our office runner(s), similar to the option mockapi already have. The timeout for mockapi and e2e tests is now also based on the number of test runs to avoid a high number of runs resulting in reaching timeout.
The changes can be tested by running the Android - Build and test workflow on this branch.
This change is