Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministically use trailing commas throughout kotlin code #6697

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Aug 28, 2024

This PR aims to add trailing commas throughout the kotlin code by reformatting all kotlin code with the recently released version of ktfmt (0.52) and the ktfmt gradle plugin (0.20.1). The new version of ktfmt also include a few other minor formatting changes.


This change is Reviewable

This commit mostly adds trailing commas throughout the project,
but also includes a few other formatting changes.
@albin-mullvad albin-mullvad added the Android Issues related to Android label Aug 28, 2024
@albin-mullvad albin-mullvad self-assigned this Aug 28, 2024
Copy link

linear bot commented Aug 28, 2024

These functions are better refactored separately
from the current work with reformatting the code.
@albin-mullvad albin-mullvad force-pushed the deterministically-use-trailing-commas-in-kotlin-code-droid-89 branch from ae4d72b to 981e97d Compare August 28, 2024 19:19
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 359 of 362 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit 1ee762f into main Aug 29, 2024
34 checks passed
@albin-mullvad albin-mullvad deleted the deterministically-use-trailing-commas-in-kotlin-code-droid-89 branch August 29, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants