Create accounts using partner API when available #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkisemils
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
rablador
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:
buggmagnet
force-pushed
the
more-descriptive-fail-for-api-function-error
branch
from
b9c7fac
to
d5ef126
Compare
buggmagnet
force-pushed
the
more-descriptive-fail-for-api-function-error
branch
from
d5ef126
to
4fd7110
Compare
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End to end test runs on PR updates were hitting the app API rate limit because accounts were created too often from the office IP address. With the changes in this PR accounts will be created using partner API if a partner API token is available, else fall back to app API. Also fail messages have been improved.
The changes in this PR can be tested by running end to end tests, especially the tests under
AccountTests.This change is