Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings #6792

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Build warnings #6792

merged 1 commit into from
Sep 18, 2024

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Sep 16, 2024

This PR resolves several build warnings by addressing issues related to Swiftlint.


This change is Reviewable

Copy link

linear bot commented Sep 16, 2024

IOS-784 Build warnings

@mojganii mojganii self-assigned this Sep 16, 2024
@mojganii mojganii added the iOS Issues related to iOS label Sep 16, 2024
@mojganii mojganii changed the title Fix some build warnings Build warnings Sep 16, 2024
Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion


ios/PacketTunnelCore/Actor/ConnectionConfigurationBuilder.swift line 22 at r1 (raw file):

}

struct ConnectionConfigurationBuilder {

I thought maybe it's not a bade idea to integrate building WG configuration in one place to have more consistency and control over future development.

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)


ios/PacketTunnelCore/Actor/ConnectionConfigurationBuilder.swift line 22 at r1 (raw file):

Previously, mojganii wrote…

I thought maybe it's not a bade idea to integrate building WG configuration in one place to have more consistency and control over future development.

I like it 👍

buggmagnet
buggmagnet previously approved these changes Sep 18, 2024
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great initiative there !!
:lgtm:

Reviewed 11 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)


ios/PacketTunnelCore/Actor/ConnectionConfigurationBuilder.swift line 106 at r1 (raw file):

    let ephemeralPeerNegotiationState: EphemeralPeerNegotiationState

    var name: String {

nit
This is only used for debugging purposes, I don't think we need to make this a localised string

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: 11 of 12 files reviewed, 2 unresolved discussions (waiting on @mojganii and @rablador)

@buggmagnet buggmagnet merged commit 4dd0be3 into main Sep 18, 2024
7 of 9 checks passed
@buggmagnet buggmagnet deleted the fix-build-warnings-ios-784 branch September 18, 2024 10:41
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants