-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build warnings #6792
Build warnings #6792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion
ios/PacketTunnelCore/Actor/ConnectionConfigurationBuilder.swift
line 22 at r1 (raw file):
} struct ConnectionConfigurationBuilder {
I thought maybe it's not a bade idea to integrate building WG configuration in one place to have more consistency and control over future development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/PacketTunnelCore/Actor/ConnectionConfigurationBuilder.swift
line 22 at r1 (raw file):
Previously, mojganii wrote…
I thought maybe it's not a bade idea to integrate building WG configuration in one place to have more consistency and control over future development.
I like it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)
ios/PacketTunnelCore/Actor/ConnectionConfigurationBuilder.swift
line 106 at r1 (raw file):
let ephemeralPeerNegotiationState: EphemeralPeerNegotiationState var name: String {
nit
This is only used for debugging purposes, I don't think we need to make this a localised string
e5e6c96
to
c5b0631
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 11 of 12 files reviewed, 2 unresolved discussions (waiting on @mojganii and @rablador)
🚨 End to end tests failed. Please check the failed workflow run. |
This PR resolves several build warnings by addressing issues related to
Swiftlint
.This change is