Make the packet tunnel enter error state when failing device check #6813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
device-rotation-failure-does-not-enter-blocked-state-ios-826
branch
from
08456d4
to
f45f874
Compare
buggmagnet
deleted the
device-rotation-failure-does-not-enter-blocked-state-ios-826
branch
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that when a device check error happens on each connection of the Packet Tunnel, we do enter the error state instead of silently logging the issue and doing nothing.
When this happens, the users will be told via the in app banner that they will have to log out and log in again because their device's integrity couldn't be checked.
This change is