Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for android/2024.5-beta1 #6823

Merged

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Sep 20, 2024


This change is Reviewable

@Rawa Rawa added the Android Issues related to Android label Sep 20, 2024
@Rawa Rawa self-assigned this Sep 20, 2024
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Rawa)


android/src/main/play/release-notes/en-US/default.txt line 1 at r1 (raw file):
I suggest adding an item at the bottom for predictive back, especially since some users might be confused by the changed behavior:

Add support for predictive back animations (on supported devices).

(included "animations" since I believe that's the most obvious for users. I guess "transitions" could work as well)


android/src/main/play/release-notes/en-US/default.txt line 1 at r1 (raw file):

- Add support for DAITA (Defence against AI-guided Analysis)

nit: end each entry with a dot


android/src/main/play/release-notes/en-US/default.txt line 2 at r1 (raw file):
nit: usually written with hyphens:

WireGuard-over-Shadowsocks

Code quote:

WireGuard over Shadowsocks

@Rawa Rawa changed the base branch from main to prepare-android/2024.5 September 20, 2024 07:16
@Rawa Rawa force-pushed the update-changelog-for-android-2024.5-beta1 branch 3 times, most recently from 505cb6f to 9a34940 Compare September 20, 2024 07:36
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Rawa)

@Rawa Rawa force-pushed the update-changelog-for-android-2024.5-beta1 branch from 9a34940 to 77bf44c Compare September 20, 2024 10:41
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa merged commit fbdb8df into prepare-android/2024.5 Sep 20, 2024
29 checks passed
@Rawa Rawa deleted the update-changelog-for-android-2024.5-beta1 branch September 20, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants