Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint and cover tests and scripts #6831

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Update eslint and cover tests and scripts #6831

merged 3 commits into from
Sep 24, 2024

Conversation

raksooo
Copy link
Member

@raksooo raksooo commented Sep 20, 2024 •
edited by faern
Loading

This PR:

  • Updates ESLint, Prettier and related dependencies
  • Updates codebase to follow new rules in new versions of tools
  • Adds test/, script/ and config files that will be linted
  • Fixes a huge number of problems reported by the linter the the above mentioned directories and files

This change is Reviewable

@linear Linear
Copy link

linear bot commented Sep 20, 2024

DES-1254 Make ESLint and other tools run for all parts of the project

@raksooo raksooo marked this pull request as ready for review September 23, 2024 14:55
MarkusPettersson98
MarkusPettersson98 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! 🎉

:lgtm:

Reviewed 60 of 60 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@raksooo raksooo force-pushed the make-eslint-and-other-tools-run-for-all-parts-of-the-project-des-1254 branch from ac4ac62 to 4bb2561 Compare September 24, 2024 11:18
@raksooo raksooo merged commit 78aea03 into main Sep 24, 2024
11 checks passed
@raksooo raksooo deleted the make-eslint-and-other-tools-run-for-all-parts-of-the-project-des-1254 branch September 24, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkusPettersson98 MarkusPettersson98 MarkusPettersson98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raksooo @MarkusPettersson98