-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler concurrency issues #6843
base: main
Are you sure you want to change the base?
Fix compiler concurrency issues #6843
Conversation
55c7a9e
to
1777c0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 59 files reviewed, 1 unresolved discussion
ios/PacketTunnelCore/Actor/Task+Duration.swift
line 64 at r2 (raw file):
} } onCancel: { timer.cancel()
This timer actually yields a warning, but I don't know how to make DispatchSourceTimer
sendable since it's a system provided protocol. sleepUsingContinuousClock()
will be deprecated in next iOS version, so perhaps we can leave it as is.
1777c0c
to
ebb4022
Compare
54b8c2b
to
7bac16e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will put this PR on hold since compiler (xcode 15.0.1) on CI reports errors not on later xcode versions (16 and onwards).
Reviewable status: 0 of 59 files reviewed, 1 unresolved discussion
7bac16e
to
a2007d2
Compare
Find all occurrences of types that are being shared across actor boundaries. For each type, determine if they are sendable as is or if they need to be refactored to be sendable.
The swift compiler should guide us to find the types that are being sent, when enforcing strict concurrency checks.
This ticket fixes issues reported up to checking level "targeted".
This change is