Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for encrypted dns proxy #6844

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Sep 23, 2024

This PR adds the UI part of the Encrypted DNS proxy to the default API access methods. An upcoming PR will connect the backend to the client side.

Before After

This change is Reviewable

Copy link

linear bot commented Sep 23, 2024

@mojganii mojganii self-assigned this Sep 23, 2024
@mojganii mojganii added iOS Issues related to iOS feature request For issues asking for new features labels Sep 23, 2024
@mojganii mojganii force-pushed the add-ui-for-encrypted-dns-proxy-ios-819 branch 2 times, most recently from 126af57 to f0d0c67 Compare September 24, 2024 09:01
pinkisemils
pinkisemils previously approved these changes Sep 25, 2024
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 15 of 15 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

rablador
rablador previously approved these changes Sep 25, 2024
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but tests need fixing.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mojganii mojganii dismissed stale reviews from rablador and pinkisemils via 741a575 September 25, 2024 10:33
@mojganii mojganii force-pushed the add-ui-for-encrypted-dns-proxy-ios-819 branch from f0d0c67 to 741a575 Compare September 25, 2024 10:33
Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Reviewable status: 14 of 16 files reviewed, all discussions resolved (waiting on @pinkisemils and @rablador)

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 14 of 16 files reviewed, 1 unresolved discussion (waiting on @mojganii and @rablador)


ios/MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift line 35 at r2 (raw file):

        let storedMethods = repository.fetchAll()

        XCTAssertEqual(storedMethods.filter { $0.isEnabled && $0.kind.isPermanent }.count, 3)

We should still verify that it contains .direct, .bridges and .encryptedDns.

rablador
rablador previously approved these changes Sep 25, 2024
Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 15 of 16 files reviewed, 1 unresolved discussion (waiting on @pinkisemils and @rablador)


ios/MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift line 35 at r2 (raw file):

Previously, pinkisemils (Emīls Piņķis) wrote…

We should still verify that it contains .direct, .bridges and .encryptedDns.

Done.

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 15 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii and @pinkisemils)


ios/MullvadSettings/AccessMethodRepositoryProtocol.swift line 47 at r1 (raw file):

    ///  Refreshes the storage with default values.
    func addDefaultsMethods()

Why did we rename this ? The previous name was quite explicit, and carried some explanation with it, I think we should revert this change.

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

@pinkisemils pinkisemils merged commit 9c0f7d7 into main Sep 25, 2024
9 of 10 checks passed
@pinkisemils pinkisemils deleted the add-ui-for-encrypted-dns-proxy-ios-819 branch September 25, 2024 13:33
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request For issues asking for new features iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants