-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI for encrypted dns proxy #6844
Conversation
126af57
to
f0d0c67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 15 of 15 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but tests need fixing.
Reviewable status: complete! all files reviewed, all discussions resolved
f0d0c67
to
741a575
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
Reviewable status: 14 of 16 files reviewed, all discussions resolved (waiting on @pinkisemils and @rablador)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 14 of 16 files reviewed, 1 unresolved discussion (waiting on @mojganii and @rablador)
ios/MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift
line 35 at r2 (raw file):
let storedMethods = repository.fetchAll() XCTAssertEqual(storedMethods.filter { $0.isEnabled && $0.kind.isPermanent }.count, 3)
We should still verify that it contains .direct
, .bridges
and .encryptedDns
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
741a575
to
56b3d6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 15 of 16 files reviewed, 1 unresolved discussion (waiting on @pinkisemils and @rablador)
ios/MullvadVPNTests/MullvadSettings/APIAccessMethodsTests.swift
line 35 at r2 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
We should still verify that it contains
.direct
,.bridges
and.encryptedDns
.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 15 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii and @pinkisemils)
ios/MullvadSettings/AccessMethodRepositoryProtocol.swift
line 47 at r1 (raw file):
/// Refreshes the storage with default values. func addDefaultsMethods()
Why did we rename this ? The previous name was quite explicit, and carried some explanation with it, I think we should revert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
🚨 End to end tests failed. Please check the failed workflow run. |
This PR adds the UI part of the Encrypted DNS proxy to the default API access methods. An upcoming PR will connect the backend to the client side.
This change is