Upgrade tonic and prost
#6847
Merged
Upgrade tonic and prost
#6847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulthe
reviewed
Sep 23, 2024
Serock3
force-pushed
the
upgrade-to-latest-tonic-012-des-1237
branch
4 times, most recently
from
a20312a
to
f3853e5
Compare
hulthe
previously approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Reviewed 2 of 8 files at r1, 12 of 14 files at r2, 7 of 7 files at r3, 4 of 4 files at r4, 3 of 3 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Serock3
force-pushed
the
upgrade-to-latest-tonic-012-des-1237
branch
2 times, most recently
from
d3e819e
to
583cb9a
Compare
Also regroup networking-related crates
Upgrading `tonic` is a prerequisite to later on upgrading `hyper` to version 1.0. As of version 1.0, `hyper` no longer uses `tokio`s `AsyncWriter` and `AsyncReader` traits, instead defining its own versions, see <hyperium/hyper#3110>. As tonic `0.12` is updated to use the `hyper 1.0` ecosystem, it changed some of its trait-bounds to the new `hyper` traits. The `hyper-utils` crate provides the wrapper `TokioIo`, which converts between the two. `prost` had to be upgraded as well, for compatibility.
Serock3
force-pushed
the
upgrade-to-latest-tonic-012-des-1237
branch
from
583cb9a
to
cb234d5
Compare
hulthe
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r6, all commit messages.
Reviewable status:
dlon
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Reviewed 11 of 14 files at r2, 5 of 7 files at r3, 4 of 4 files at r4, 1 of 3 files at r5, 3 of 3 files at r6, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
tonicto version 0.12, as a prerequisite to later on upgradinghyper.As of version 1,
hyperno longer uses tokiosAsyncWriterandAsyncReadertraits, instead defining its own versions, see hyperium/hyper#3110. As tonic0.12is updated to use thehyper 1.0ecosystem, it changed some of its trait-bounds to the newhypertraits. Thehyper-utilscrate provides the wrapperTokioIo, which converts between the two.prosthad to be upgraded as well, for compatibility.This change is