Don't hijack DNS config when localhost is used

[dlon]

If the resolver is set to (e.g.) 127.0.0.1, don't replace it with 10.64.0.1. Hopefully prevents some fighting with other software.

This does not change affect any of the firewall rules.

Close DES-1227.

---

This change is 

[linear]

DES-1227 Allow DNS resolvers on 127.0.0.0/8 on macOS

[MarkusPettersson98]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)

---

talpid-core/src/dns/macos.rs line 196 at r1 (raw file):

        set.filter_map(|addr| addr.parse::<IpAddr>().ok())
            .find(|addr| addr.is_loopback())
            .is_some()

As clippy suggets, prefer any here 😊

set.filter_map(|addr| addr.parse::<IpAddr>().ok())
   .any(|addr| addr.is_loopback())

Code quote:

            .find(|addr| addr.is_loopback())
            .is_some()

[dlon]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)

---

talpid-core/src/dns/macos.rs line 196 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

As clippy suggets, prefer any here 😊

set.filter_map(|addr| addr.parse::<IpAddr>().ok())
   .any(|addr| addr.is_loopback())

Done.

[MarkusPettersson98]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved