Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring core privacy features forward #6866

Merged
merged 10 commits into from
Sep 30, 2024

Conversation

raksooo
Copy link
Member

@raksooo raksooo commented Sep 25, 2024

This PR brings core privacy features forward. The changes include:

  • Move Multihop and DAITA to be accessible from Settings.tsx
  • Move Multihop setting into a dedicated view
  • Add illustrations and more information to the Multihop and DAITA views
  • Remove multihop confirmation dialog

To be able to show the information in a paged layout in DaitaSettings.tsx I implemented the component PageSlider.tsx.


This change is Reviewable

Copy link

linear bot commented Sep 25, 2024

@raksooo raksooo force-pushed the implement-design-for-brought-forward-features-des-1065 branch 2 times, most recently from 16864b2 to c069ab1 Compare September 25, 2024 13:04
CHANGELOG.md Outdated Show resolved Hide resolved
@raksooo raksooo force-pushed the implement-design-for-brought-forward-features-des-1065 branch 2 times, most recently from 345a345 to 21ca705 Compare September 26, 2024 15:36
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 3 of 4 files at r4, 1 of 2 files at r5, 2 of 3 files at r7, 3 of 3 files at r8, 1 of 1 files at r9, 1 of 1 files at r10, 1 of 1 files at r11, 2 of 2 files at r12, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MrChocolatine and @raksooo)


gui/src/renderer/components/PageSlider.tsx line 159 at r11 (raw file):

  [`${StyledTransparentButton}:hover &&`]: {
    backgroundColor: props.$current ? colors.white80 : colors.white80,

white80 or white80?

@raksooo raksooo force-pushed the implement-design-for-brought-forward-features-des-1065 branch from 21ca705 to e1fe458 Compare September 26, 2024 16:07
Copy link
Member Author

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 13 files reviewed, 1 unresolved discussion (waiting on @hulthe and @MrChocolatine)


gui/src/renderer/components/PageSlider.tsx line 159 at r11 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

white80 or white80?

Oops, fixed!

hulthe
hulthe previously approved these changes Sep 26, 2024
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r14, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MrChocolatine)

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 5 files at r1, 3 of 4 files at r4, 9 of 9 files at r13, 9 of 9 files at r14, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MrChocolatine and @raksooo)


gui/src/renderer/components/DaitaSettings.tsx line 2 at r14 (raw file):

import { useCallback } from 'react';
import React from 'react';

Nit These imports could be consolidated into one line

import React, { useCallback } from 'react';

Code quote:

import { useCallback } from 'react';
import React from 'react';

@raksooo raksooo force-pushed the implement-design-for-brought-forward-features-des-1065 branch from e1fe458 to 6b227fd Compare September 30, 2024 07:20
@raksooo raksooo force-pushed the implement-design-for-brought-forward-features-des-1065 branch from 6b227fd to e15e49c Compare September 30, 2024 07:23
Copy link
Member Author

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 13 files reviewed, 1 unresolved discussion (waiting on @hulthe, @MarkusPettersson98, and @MrChocolatine)


gui/src/renderer/components/DaitaSettings.tsx line 2 at r14 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Nit These imports could be consolidated into one line

import React, { useCallback } from 'react';

Done.

Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 4 files at r17, 1 of 2 files at r18, 2 of 3 files at r20, 3 of 3 files at r21, 1 of 1 files at r22, 1 of 1 files at r23, 1 of 1 files at r24, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MrChocolatine)

@raksooo raksooo merged commit 978211c into main Sep 30, 2024
11 of 12 checks passed
@raksooo raksooo deleted the implement-design-for-brought-forward-features-des-1065 branch September 30, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants