-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring core privacy features forward #6866
Bring core privacy features forward #6866
Conversation
16864b2
to
c069ab1
Compare
345a345
to
21ca705
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1, 3 of 4 files at r4, 1 of 2 files at r5, 2 of 3 files at r7, 3 of 3 files at r8, 1 of 1 files at r9, 1 of 1 files at r10, 1 of 1 files at r11, 2 of 2 files at r12, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MrChocolatine and @raksooo)
gui/src/renderer/components/PageSlider.tsx
line 159 at r11 (raw file):
[`${StyledTransparentButton}:hover &&`]: { backgroundColor: props.$current ? colors.white80 : colors.white80,
white80 or white80?
21ca705
to
e1fe458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 13 files reviewed, 1 unresolved discussion (waiting on @hulthe and @MrChocolatine)
gui/src/renderer/components/PageSlider.tsx
line 159 at r11 (raw file):
Previously, hulthe (Joakim Hulthe) wrote…
white80 or white80?
Oops, fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r14, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MrChocolatine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1, 3 of 4 files at r4, 9 of 9 files at r13, 9 of 9 files at r14, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MrChocolatine and @raksooo)
gui/src/renderer/components/DaitaSettings.tsx
line 2 at r14 (raw file):
import { useCallback } from 'react'; import React from 'react';
Nit These imports could be consolidated into one line
import React, { useCallback } from 'react';
Code quote:
import { useCallback } from 'react';
import React from 'react';
6b227fd
e1fe458
to
6b227fd
Compare
6b227fd
to
e15e49c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 13 files reviewed, 1 unresolved discussion (waiting on @hulthe, @MarkusPettersson98, and @MrChocolatine)
gui/src/renderer/components/DaitaSettings.tsx
line 2 at r14 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Nit These imports could be consolidated into one line
import React, { useCallback } from 'react';
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r17, 1 of 2 files at r18, 2 of 3 files at r20, 3 of 3 files at r21, 1 of 1 files at r22, 1 of 1 files at r23, 1 of 1 files at r24, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MrChocolatine)
This PR brings core privacy features forward. The changes include:
Settings.tsx
To be able to show the information in a paged layout in
DaitaSettings.tsx
I implemented the componentPageSlider.tsx
.This change is