-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all x86_64 mentions from iOS CI and build scripts #6868
Remove all x86_64 mentions from iOS CI and build scripts #6868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/BuildInstructions.md
line 15 at r1 (raw file):
rustup target install aarch64-apple-ios aarch64-apple-ios-simYou only need to install the ARM simulator target, which matches the current Apple Silicon (M1/M2) architecture.
We can remove the (M1/M2)
part, Apple Silicon
is already the official name of this technology
96be50b
to
9fa2aba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/BuildInstructions.md
line 15 at r1 (raw file):
Previously, buggmagnet wrote…
We can remove the
(M1/M2)
part,Apple Silicon
is already the official name of this technology
Done.
9fa2aba
to
7ac8dd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved
7ac8dd6
to
30b41d5
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
This PR removes all references to the x86_64 architecture from the iOS CI pipeline and build scripts.
This change is