Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all x86_64 mentions from iOS CI and build scripts #6868

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Sep 25, 2024

This PR removes all references to the x86_64 architecture from the iOS CI pipeline and build scripts.


This change is Reviewable

Copy link

linear bot commented Sep 25, 2024

@mojganii mojganii changed the title Drop x86_64 Remove all x86_64 mentions from iOS CI and build scripts Sep 25, 2024
@mojganii mojganii self-assigned this Sep 25, 2024
@mojganii mojganii added iOS Issues related to iOS enhancement labels Sep 25, 2024
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @mojganii)


ios/BuildInstructions.md line 15 at r1 (raw file):

rustup target install aarch64-apple-ios aarch64-apple-ios-sim

You only need to install the ARM simulator target, which matches the current Apple Silicon (M1/M2) architecture.

We can remove the (M1/M2) part, Apple Silicon is already the official name of this technology

@mojganii mojganii force-pushed the remove-x86_64-from-ci-and-build-scripts-ios-797 branch from 96be50b to 9fa2aba Compare September 30, 2024 15:08
Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


ios/BuildInstructions.md line 15 at r1 (raw file):

Previously, buggmagnet wrote…

We can remove the (M1/M2) part, Apple Silicon is already the official name of this technology

Done.

@mojganii mojganii force-pushed the remove-x86_64-from-ci-and-build-scripts-ios-797 branch from 9fa2aba to 7ac8dd6 Compare October 1, 2024 15:15
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the remove-x86_64-from-ci-and-build-scripts-ios-797 branch from 7ac8dd6 to 30b41d5 Compare October 1, 2024 15:22
@buggmagnet buggmagnet merged commit 9e290ac into main Oct 1, 2024
8 of 9 checks passed
@buggmagnet buggmagnet deleted the remove-x86_64-from-ci-and-build-scripts-ios-797 branch October 1, 2024 15:25
Copy link

github-actions bot commented Oct 1, 2024

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants